Adding pre upgrade tests - #417
Conversation
[noissue]
5669de6 to
2ae70d4
Compare
|
@gerrod3 can I have a review + merge? |
| # Step 8 | ||
| url = self.cfg.get_content_host_base_url() + "/pypi/pulp_pre_upgrade_test/" | ||
| self.assertEqual(url, distribution.base_url, url) |
There was a problem hiding this comment.
I don't understand how this test is passing. What does cfg.get_content_host_base_url() return? Is it the content app url, aka PULP_CONTENT_ORIGIN or is it the hostname of the Pulp-API? The url you are testing against won't exist in 3.2 as the "new" pypi api was added in 3.4.
There was a problem hiding this comment.
it is the pulp-api hostname, it is built from here https://github.com/pulp/pulp_python/blob/master/.ci/ansible/smash-config.json#L10-L22
| echo "Milestone: $MILESTONE" | ||
| pip install python-redmine httpie | ||
|
|
||
| if [[ "$MILESTONE" != "${RELEASE%.post*}" ]]; then | ||
| echo "Milestone $MILESTONE is not equal to Release $RELEASE" | ||
| exit 1 | ||
| fi | ||
|
|
||
| pip install python-redmine | ||
| python3 .ci/scripts/redmine.py $REDMINE_QUERY_URL | ||
| python3 .ci/scripts/redmine.py $REDMINE_QUERY_URL $MILESTONE_URL $RELEASE |
There was a problem hiding this comment.
Weird that these got added since python uses github issues. Guess these spots don't use the setting from the template when auto-generating these files.
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: "3.8" |
There was a problem hiding this comment.
Should this be python 3.6 for pulp_python 3.2? I'm not sure it matters much since I probably won't be making any backport releases from this branch, but just curious if this is a missed spot for the python version on the template CI.
There was a problem hiding this comment.
I need to change it on plugin-template
|
@fao89 I see that the new pre-upgrade test isn't ran in the CI. Is that test only ran on master branch? |
2 participants
[noissue]