Minor improvements on plugin-template - #474
Merged
Merged
Conversation
mdellweg
reviewed
Aug 24, 2021
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: "3.8" | ||
| python-version: "{{ python_version }}" |
Member
There was a problem hiding this comment.
I think i remember, we discussed this. And the release workflow does not run any pulp code so we opted out from making the python version flexible.
Am i right here? @daviddavis
Contributor
There was a problem hiding this comment.
That's basically correct except I believe there was release Python code that didn't wasn't compatible with older versions of Python.
Contributor
There was a problem hiding this comment.
The release code does use python_version when running tests:
daviddavis
reviewed
Aug 24, 2021
| - uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: "3.8" | ||
| python-version: "{{ python_version }}" |
Contributor
There was a problem hiding this comment.
This workflow doesn't run Pulp at all so I don't see any benefit to changing this to python_version instead of 3.8.
[noissue]
daviddavis
approved these changes
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[noissue]