Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/412.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added new setting ``PYPI_API_HOSTNAME`` that is used to form a distribution's ``base_url``. Defaults to the machine's FQDN.
2 changes: 1 addition & 1 deletion pulp_python/app/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from django.contrib.postgres.fields import ArrayField, JSONField
from django.core.exceptions import ObjectDoesNotExist
from django.db import models
from dynaconf import settings
from django.conf import settings
from yarl import URL

from pulpcore.plugin.models import (
Expand Down
4 changes: 2 additions & 2 deletions pulp_python/app/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import tempfile

from django.core.files.storage import default_storage as storage
from django.conf import settings
from packaging.requirements import Requirement
from rest_framework import serializers

Expand All @@ -12,7 +13,6 @@
from pulp_python.app import models as python_models
from pulp_python.app.tasks.upload import DIST_EXTENSIONS, DIST_TYPES
from pulp_python.app.utils import parse_project_metadata
from pulp_python.app.urls import PYPI_API_HOSTNAME


class PythonRepositorySerializer(core_serializers.RepositorySerializer):
Expand Down Expand Up @@ -54,7 +54,7 @@ class PythonDistributionSerializer(core_serializers.DistributionSerializer):

def get_base_url(self, obj):
"""Gets the base url."""
return f"{PYPI_API_HOSTNAME}/pypi/{obj.base_path}/"
return f"{settings.PYPI_API_HOSTNAME}/pypi/{obj.base_path}/"

def validate(self, data):
"""
Expand Down
3 changes: 3 additions & 0 deletions pulp_python/app/settings.py
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
import socket

PYTHON_GROUP_UPLOADS = False
PYPI_API_HOSTNAME = 'https://' + socket.getfqdn()
2 changes: 0 additions & 2 deletions pulp_python/app/urls.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import socket
from django.urls import path

from pulp_python.app.pypi.views import SimpleView, MetadataView, PyPIView, UploadView

PYPI_API_URL = 'pypi/<path:path>/'
PYPI_API_HOSTNAME = 'https://' + socket.getfqdn()
# TODO: Implement remaining PyPI endpoints
# path("project/", PackageProject.as_view()), # Endpoints to nicely see contents of index
# path("search/", PackageSearch.as_view()),
Expand Down