Add new setting to expose hostname for base_url - #415
Merged
Conversation
gerrod3
force-pushed
the
base_url_setting
branch
from
August 20, 2021 23:57
fdf921d to
6c23a8a
Compare
dralley
reviewed
Aug 21, 2021
| import tempfile | ||
|
|
||
| from django.core.files.storage import default_storage as storage | ||
| from dynaconf import settings |
Contributor
There was a problem hiding this comment.
If this works, that's neat :)
But for consistency lets use from django.conf import settings
gerrod3
force-pushed
the
base_url_setting
branch
from
August 21, 2021 00:08
6c23a8a to
435f546
Compare
dralley
approved these changes
Aug 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #412