SP ARM64: Fix code to compile under GreenHills#10890
Open
SparkiDev wants to merge 1 commit into
Open
Conversation
1. adds with negative immediate -> subs (14 sites): "adds %[c], %[c], #-1" -> "subs %[c], %[c], #1" 2. cmp with negative immediate -> cmn (28 sites): e.g. "cmp x6, -7" -> "cmn x6, 7" 3. # asm comments -> C comments (~1260 sites): "# A[0] * B[0]\n\t" -> /* A[0] * B[0] */ (GreenHills' assembler rejects # line comments) 4. Deduplicated register clobber lists (~9 lines): removed repeated registers like "x8", "x8" from the : "memory", …, "cc" clobber lists
Contributor
Author
|
Code generated with PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#asm comments -> C comments (~1260 sites): "# A[0] * B[0]\n\t" -> /* A[0]Fixes zd#22072
Testing
Compiles with GCC.