Skip to content

Fix LT-22632: Show # of changed analyses in Run Tests report - #1024

Merged
jtmaxwell3 merged 4 commits into
mainfrom
LT-22632
Jul 28, 2026
Merged

Fix LT-22632: Show # of changed analyses in Run Tests report#1024
jtmaxwell3 merged 4 commits into
mainfrom
LT-22632

Conversation

@jtmaxwell3

@jtmaxwell3 jtmaxwell3 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

This implements https://jira.sil.org/browse/LT-22632. It adds a column that reports the number of analyses that changed since the last time that a word was parsed. This is only meaningful if Updates Word Analyses is disabled, so it hides the column if it is enabled. This is useful if you are trying to speed up a grammar without changing any of the analyses. Then you can

  1. Parse a corpus to establish a baseline.
  2. Disable Updates Word Analyses.
  3. Make changes to the grammar.
  4. Invoke Run tests on the corpus.
  5. Verify that the number of changed analyses is zero for the corpus.
  6. Verify that the corpus parses faster.
  7. Go to step 3.

This change is Reviewable

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 20s ⏱️ -49s
4 313 tests ±0  4 240 ✅ ±0  73 💤 ±0  0 ❌ ±0 
4 322 runs  ±0  4 249 ✅ ±0  73 💤 ±0  0 ❌ ±0 

Results for commit 603eba2. ± Comparison against base commit 7176e6c.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@2e3576f). Learn more about missing BASE report.
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
Src/LexText/ParserCore/ParserReport.cs 88.63% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage        ?   33.04%           
=======================================
  Files           ?     1202           
  Lines           ?   278319           
  Branches        ?    37190           
=======================================
  Hits            ?    91967           
  Misses          ?   158495           
  Partials        ?    27857           
Files with missing lines Coverage Δ
Src/LexText/ParserCore/ParserReport.cs 67.88% <88.63%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

<value>Num Changed Analyses</value>
</data>
<data name="ksTotalChangedAnalysesToolTip" xml:space="preserve">
<value>The total number of changed analyses since the last parse</value>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "The total number of analyses that have changed since the last parse" would be more consistent with the other new tooltip.

@jtmaxwell3
jtmaxwell3 merged commit c8f63c5 into main Jul 28, 2026
6 of 7 checks passed
@jtmaxwell3
jtmaxwell3 deleted the LT-22632 branch July 28, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants