Add and update specs for IO methods

core/io/binmode_spec.rb

@@ -31,6 +31,142 @@
     @io.binmode
     @io.internal_encoding.should == nil
   end
+
+  it "disables newline conversion for #read" do
+    data = "line1\r\nline2\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.read.should == data
+  end
+
+  it "disables newline conversion for #gets" do
+    data = "line1\r\nline2\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.gets.should == "line1\r\n"
+    @io.gets.should == "line2\r\n"
+  end
+
+  it "disables newline conversion for #readline" do
+    data = "line1\r\nline2\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.readline.should == "line1\r\n"
+    @io.readline.should == "line2\r\n"
+  end
+
+  it "disables newline conversion for #readlines" do
+    data = "line1\r\nline2\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.readlines.should == ["line1\r\n", "line2\r\n"]
+  end
+
+  it "disables newline conversion for #each" do
+    data = "line1\r\nline2\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.each.to_a.should == ["line1\r\n", "line2\r\n"]
+  end
+
+  it "disables newline conversion for #each_line" do
+    data = "line1\r\nline2\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.each_line.to_a.should == ["line1\r\n", "line2\r\n"]
+  end
+
+  it "disables newline conversion for #getc" do
+    data = "line1\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    5.times { @io.getc }
+    @io.getc.should == "\r"
+    @io.getc.should == "\n"
+  end
+
+  it "disables newline conversion for #readchar" do
+    data = "line1\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    5.times { @io.readchar }
+    @io.readchar.should == "\r"
+    @io.readchar.should == "\n"
+  end
+
+  it "disables newline conversion for #each_char" do
+    data = "line1\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.each_char.to_a.should == ["l", "i", "n", "e", "1", "\r", "\n"]
+  end
+
+  it "disables newline conversion for #each_codepoint" do
+    data = "line1\r\n"
+
+    @io = new_io(@name, "wb")
+    @io.write(data)
+    @io.close
+
+    @io = new_io(@name, "rt")
+    @io.set_encoding("utf-8:ISO-8859-1", newline: :universal)
+    @io.binmode
+    @io.each_codepoint.to_a.should == [108, 105, 110, 101, 49, 13, 10]
+  end
 end
 
 describe "IO#binmode?" do

core/io/getbyte_spec.rb

@@ -25,6 +25,13 @@
   it "raises an IOError on closed stream" do
     -> { IOSpecs.closed_io.getbyte }.should.raise(IOError)
   end
+
+  it "reads after ungetc without character conversion" do
+    @io.set_encoding("utf-8")
+    c = @io.getc
+    @io.ungetc(c)
+    @io.getbyte.should == 86
+  end
 end
 
 describe "IO#getbyte" do

core/io/internal_encoding_spec.rb

@@ -93,6 +93,11 @@
       @io = new_io @name, "#{@object}:binary"
       @io.internal_encoding.should == nil
     end
+
+    it "returns nil when the external encoding is BINARY and internal encoding is set" do
+      @io = new_io @name, "#{@object}:binary:ibm437"
+      @io.internal_encoding.should == nil
+    end
   end
 end
 

core/io/pwrite_spec.rb

@@ -59,6 +59,12 @@
     }.should.raise(NoMethodError, /undefined method [`']to_s'/)
   end
 
+  it "raises a Errno::EINVAL if the offset is invalid" do
+    -> {
+      @file.pwrite("foo", -3)
+    }.should.raise(Errno::EINVAL)
+  end
+
   it "raises a TypeError if the offset cannot be converted to an Integer" do
     -> {
       @file.pwrite("foo", Object.new)

core/io/read_nonblock_spec.rb

@@ -66,16 +66,6 @@
     @read.read_nonblock(3).should == "bar"
   end
 
-  it "raises an exception after ungetc with data in the buffer and character conversion enabled" do
-    @write.write("foobar")
-    @read.set_encoding(
-      'utf-8', universal_newline: true
-    )
-    c = @read.getc
-    @read.ungetc(c)
-    -> { @read.read_nonblock(3).should == "foo" }.should.raise(IOError)
-  end
-
   it "returns less data if that is all that is available" do
     @write << "hello"
     @read.read_nonblock(10).should == "hello"
@@ -137,6 +127,14 @@
     -> { @read.read_nonblock(5) }.should.raise(EOFError)
   end
 
+  ruby_bug "#18421", ""..."3.0.4" do
+    it "clears and returns the given buffer if the length argument is 0" do
+      buffer = String.new("existing content")
+      @read.read_nonblock(0, buffer).should == buffer
+      buffer.should == ""
+    end
+  end
+
   it "preserves the encoding of the given buffer" do
     buffer = ''.encode(Encoding::ISO_8859_1)
     @write.write("abc")

core/io/read_spec.rb

@@ -672,6 +672,12 @@
         @io.read.encoding.should.equal?(Encoding::EUC_JP)
       end
 
+      it "reads after ungetc" do
+        c = @io.getc
+        @io.ungetc(c)
+        @io.read(2).should == [164, 162].pack('C*').force_encoding(Encoding::BINARY)
+      end
+
       it_behaves_like :io_read_size_internal_encoding, nil
     end
 

core/io/readbyte_spec.rb

@@ -21,4 +21,11 @@
       @io.readbyte
     end.should.raise EOFError
   end
+
+  it "reads after ungetc without character conversion" do
+    @io.set_encoding("utf-8")
+    c = @io.getc
+    @io.ungetc(c)
+    @io.readbyte.should == ?r.getbyte(0)
+  end
 end

core/io/reopen_spec.rb

@@ -57,6 +57,10 @@
     @io.close
     -> { @io.reopen(STDOUT) }.should.raise(IOError)
   end
+
+  it "raises ArgumentError when too many arguments are given" do
+    -> { @io.reopen(@other_name, "r", "excess argument") }.should.raise(ArgumentError)
+  end
 end
 
 describe "IO#reopen with a String" do
@@ -170,6 +174,53 @@
     @io.reopen(@other_name)
     File.should.exist?(@other_name)
   end
+
+  it "opens the file in read mode if the IO is read-only" do
+    touch(@name) { |f| f.write "original data" }
+    touch(@other_name) { |f| f.write "new data" }
+    @io = new_io @name, "r"
+
+    @io.reopen(@other_name)
+    -> { @io.write("overwrite content") }.should.raise(IOError)
+    @io.read.should == "new data"
+  end
+
+  it "opens the file in write mode if the IO is write-only" do
+    touch(@name) { |f| f.write "original data" }
+    touch(@other_name) { |f| f.write "new data" }
+    @io = new_io @name, "w"
+
+    @io.reopen(@other_name)
+    -> { @io.read }.should.raise(IOError)
+    @io.write("overwrite content").should == 17
+    @io.close
+    File.read(@other_name).should == "overwrite content"
+  end
+
+  it "opens the file in read-write mode if the IO is read-write" do
+    touch(@name) { |f| f.write "original data" }
+    touch(@other_name) { |f| f.write "new data" }
+    @io = new_io @name, "r+"
+
+    @io.reopen(@other_name)
+    @io.read.should == "new data"
+    @io.rewind
+    @io.write("overwrite content").should == 17
+    @io.close
+    File.read(@other_name).should == "overwrite content"
+  end
+
+  it "opens the file in append mode if the IO appends" do
+    touch(@name) { |f| f.write "original data" }
+    touch(@other_name) { |f| f.write "new data" }
+    @io = new_io @name, "a"
+
+    @io.reopen(@other_name)
+    -> { @io.read }.should.raise(IOError)
+    @io.write("overwrite content").should == 17
+    @io.close
+    File.read(@other_name).should == "new dataoverwrite content"
+  end
 end
 
 describe "IO#reopen with a String" do

core/io/seek_spec.rb

@@ -77,6 +77,19 @@
     value[-1].should == @io.read[0]
   end
 
+  ruby_bug "#20919", "" ... "3.4" do
+    it "clears the character buffer" do
+      @io.ungetc("a")
+      @io.seek(1, IO::SEEK_SET)
+      @io.getc.should == "o"
+
+      @io.set_encoding(Encoding::UTF_8, Encoding::UTF_16LE)
+      @io.ungetc("a".encode(Encoding::UTF_16LE))
+      @io.seek(1, IO::SEEK_SET)
+      @io.getc.should == "o".encode(Encoding::UTF_16LE)
+    end
+  end
+
   platform_is :darwin do
     it "supports seek offsets greater than 2^32" do
       begin