Define HighResTimeStamp, HighResTimeDuration, HighResTimeClock#51254
Closed
hoxyq wants to merge 1 commit into
Closed
Define HighResTimeStamp, HighResTimeDuration, HighResTimeClock#51254hoxyq wants to merge 1 commit into
hoxyq wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72796412 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72796412 |
hoxyq
force-pushed
the
export-D72796412
branch
2 times, most recently
from
May 12, 2025 21:35
d883108 to
1cd3045
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72796412 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72796412 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72796412 |
hoxyq
force-pushed
the
export-D72796412
branch
2 times, most recently
from
May 16, 2025 17:13
bcda99d to
5b698ec
Compare
Summary: Pull Request resolved: #51254 # Changelog: [Internal] Defines single timestamp abstraction that will be used in C++ layer of React Native core: Key primitives include: - `HighResTimeStamp`: A class representing a specific point in time with high precision. - `HighResDuration`: A class representing a duration of time with high precision. Right now, all these just encapsulate `std::chrono::steady_clock` with no extra custom logic. We might revisit this in a future, once we decide to add support for [`Performance.timeOrigin`](https://developer.mozilla.org/en-US/docs/Web/API/Performance/timeOrigin). This diff also adds a `README.md` documentation file with a brief summary of the `react/timing` module. Reviewed By: rubennorte Differential Revision: D72796412
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72796412 |
Collaborator
|
This pull request was successfully merged by @hoxyq in a882f19 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in a882f19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Defines single timestamp abstraction that will be used in C++ layer of React Native core:
Key primitives include:
HighResTimeStamp: A class representing a specific point in time with high precision.HighResTimeDuration: A class representing a duration of time with high precision.HighResTimeClock: A class providing a monotonic clock that won't be adjusted.Right now, all these just encapsulate
std::chrono::steady_clockwith no extra custom logic. We might revisit this in a future, once we decide to add support forPerformance.timeOrigin.This diff also adds a
README.mddocumentation file with a brief summary of thereact/timingmodule.Differential Revision: D72796412