This repository was archived by the owner on May 14, 2021. It is now read-only.
Fix py2/py3 compatibility due to relative import issues - #24
Merged
Conversation
TODO: Figure out how to get imports working properly for tests and demo script without hacky hacks.
gschneider-r7
changed the title
Contributor
Author
|
Tested with a built wheel that the relative imports work correctly when fully deployed on both Python 2.7 and 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use relative imports since this is a proper package. Get rid of the hacky scripts that make the project importable for the demo and test scripts, since they are no longer needed.
Motivation and Context
Fixes #23
How Has This Been Tested?
So far I have tested it locally with virtual environments for 2.7 and 3.6. I also have this branch running on travis-ci for the full suite of tested versions, which is passing after fixing imports on the tests.
Types of changes
Checklist: