Add comments about _Py_LOCK_DONT_DETACH usage.#153817
Open
nascheme wants to merge 1 commit into
Open
Conversation
The need for _Py_LOCK_DONT_DETACH in intern_common() is not so obvious. Add some code comments explaining why we use that flag. Also, add a comment to the flag noting that you need extra care when writing code that holds a mutex with this flag set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The need for
_Py_LOCK_DONT_DETACHinintern_common()is not so obvious. Add some code comments explaining why we use that flag. Also, add a comment to the flag noting that you need extra care when writing code that holds a mutex with this flag set.