Enable Azure support#459
Merged
Merged
Conversation
fao89
force-pushed
the
azure
branch
3 times, most recently
from
October 27, 2021 14:37
bf85e3f to
bb44982
Compare
closes pulp#458
gerrod3
reviewed
Oct 28, 2021
Comment on lines
+98
to
+99
| export PYTHONPATH=$REPO_ROOT/../pulpcore${PYTHONPATH:+:${PYTHONPATH}} | ||
| export PYTHONPATH=$REPO_ROOT${PYTHONPATH:+:${PYTHONPATH}} |
Contributor
There was a problem hiding this comment.
What does this change the path to?
Member
Author
There was a problem hiding this comment.
came from pulp/plugin_template#505
I'm not entirely sure why we did it, but I think @mdellweg was helping with some issue on pulp-certguard
Member
There was a problem hiding this comment.
This helps adding al the extra plugins to the path for unittests.
gerrod3
reviewed
Oct 28, 2021
Comment on lines
+93
to
+97
| elif settings.DEFAULT_FILE_STORAGE == "storages.backends.s3boto3.S3Boto3Storage": | ||
| parameters = { | ||
| "ResponseContentDisposition": content_disposition, | ||
| "ResponseContentType": "text/html" | ||
| } |
Contributor
There was a problem hiding this comment.
Good job on finding this obscure piece of the code. I need to find some time to create a proper solution to this issue, instead of adding on to this hack, but this is the best we can do for now.
gerrod3
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #458
Checking if every plugin installed in pulp-operator can support azure
https://github.com/pulp/pulp-operator/blob/main/.ci/ansible/pulp/vars.yaml#L14-L21