Skip to content

Set https_proxy proxy setting - #445

Merged
gerrod3 merged 1 commit into
pulp:masterfrom
keilr:https_proxy_setting
Oct 5, 2021
Merged

Set https_proxy proxy setting#445
gerrod3 merged 1 commit into
pulp:masterfrom
keilr:https_proxy_setting

Conversation

@keilr

@keilr keilr commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

fixes: #433

@keilr keilr mentioned this pull request Oct 5, 2021
Closed
@gerrod3

gerrod3 commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

@keilr Thanks for the PR. To get it to pass the CI can you amend your commit message to include on the second line fixes: #433

@dralley

dralley commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Fix the CI as @gerrod3 mentioned, otherwise LGTM

@keilr
keilr force-pushed the https_proxy_setting branch from 410bbee to 1535dd2 Compare October 5, 2021 20:19
@keilr

keilr commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

@keilr Thanks for the PR. To get it to pass the CI can you amend your commit message to include on the second line fixes: #433

done

@keilr

keilr commented Oct 5, 2021

Copy link
Copy Markdown
Contributor Author

@gerrod3 please back-port this fix to 3.5 if possible

@gerrod3
gerrod3 merged commit 9957da7 into pulp:master Oct 5, 2021
gerrod3 added a commit to gerrod3/pulp_python that referenced this pull request Oct 5, 2021
@gerrod3
Set https_proxy proxy setting
8917a9a 
backports: pulp#445

fixes pulp#436

(cherry picked from commit 1535dd2)
gerrod3 added a commit to gerrod3/pulp_python that referenced this pull request Oct 5, 2021
@gerrod3
Set https_proxy proxy setting
e59e551 
backports: pulp#445

fixes pulp#436

(cherry picked from commit 1535dd2)
@gerrod3

gerrod3 commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

@gerrod3 please back-port this fix to 3.5 if possible

Here you go: https://pypi.org/project/pulp-python/3.5.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dralley dralley dralley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unable to sync python packages via proxy

3 participants

@keilr @gerrod3 @dralley