Skip to content

Publication and template fixes#414

Merged
gerrod3 merged 2 commits into
pulp:masterfrom
gerrod3:pub_and_template_fixes
Aug 20, 2021
Merged

Publication and template fixes#414
gerrod3 merged 2 commits into
pulp:masterfrom
gerrod3:pub_and_template_fixes

Conversation

@gerrod3

@gerrod3 gerrod3 commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Updating the template/CI and fixing publications on S3

@gerrod3 gerrod3 added this to the 3.5.0 milestone Aug 11, 2021
@gerrod3 gerrod3 mentioned this pull request Aug 11, 2021
Closed
@gerrod3
gerrod3 force-pushed the pub_and_template_fixes branch from e0eccb6 to 5191b7c Compare August 11, 2021 18:16
@gerrod3 gerrod3 linked an issue Aug 11, 2021 that may be closed by this pull request
Publications are broken on S3 #413
Closed
@gerrod3
gerrod3 force-pushed the pub_and_template_fixes branch from 5191b7c to 98d2cd5 Compare August 11, 2021 18:30
dralley
dralley reviewed Aug 20, 2021
View reviewed changes
Comment thread pulp_python/app/models.py
dralley
dralley reviewed Aug 20, 2021
View reviewed changes
Comment thread pulp_python/app/models.py Outdated
@gerrod3
gerrod3 force-pushed the pub_and_template_fixes branch from 98d2cd5 to d64964d Compare August 20, 2021 23:29
dralley
dralley reviewed Aug 20, 2021
View reviewed changes
Comment thread pulp_python/app/models.py
).get(relative_path=rel_path).content_artifact
except ObjectDoesNotExist:
return None
file = ca.artifact.file

@dralley dralley Aug 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a guarantee that at this point in the execution, the content artifact has a downloaded artifact and not a remote artifact? In other words, is ca.artifact guaranteed to not be None?

@gerrod3 gerrod3 Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the ca.artifact is actually a published_artifact so it is guaranteed to exist.

@dralley dralley Aug 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right. Could you rename ca to something that doesn't evoke ContentArtifact? Like pa or published_artifact

@gerrod3 gerrod3 Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but it is a ContentArtifact, PublishedArtifact uses a ContentArtifact to store its file.

@dralley dralley Aug 20, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I didn't see the .content_artifact at the end of line 83

@gerrod3
gerrod3 merged commit f81b1f2 into pulp:master Aug 20, 2021
@gerrod3
gerrod3 deleted the pub_and_template_fixes branch October 20, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dralley dralley dralley approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

Publications are broken on S3

2 participants

@gerrod3 @dralley