Add missing fields to PyPI JSON API - #379
Merged
Merged
Conversation
gerrod3
force-pushed
the
352
branch
3 times, most recently
from
June 4, 2021 22:27
2074fd8 to
e901236
Compare
dralley
reviewed
Jun 7, 2021
| classifiers = JSONField(default=list) | ||
| project_urls = JSONField(default=dict) | ||
| description_content_type = models.TextField() | ||
| provides_extra = models.TextField() |
Contributor
There was a problem hiding this comment.
I'm not 100% sure because the example here doesn't show it, but I believe this can be specified multiple times. That's my interpretation of "multiple-use"
Contributor
There was a problem hiding this comment.
Have you seen any in-the-wild examples?
Contributor
Author
There was a problem hiding this comment.
No, I haven't found any. This field doesn't seem to be exposed on PyPI, so I have no idea.
dralley
approved these changes
Jun 7, 2021
dralley
left a comment
dralley
left a comment
Contributor
There was a problem hiding this comment.
Apart from the provides_extra field which should be removed, looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #352