Autopublish fix#375
Merged
Merged
Conversation
gerrod3
force-pushed
the
autopublish_fix
branch
2 times, most recently
from
May 20, 2021 15:04
dbacb53 to
a20268d
Compare
Contributor
|
The patch looks good, but it looks like there are workflow generator changes are mixed together in the same commit with the actual fix : / I would rather this fix be merged first, and separately from the workflow changes. It would leave a much cleaner git history, and be easier to review 1-to-1 against the matching pulp_file and pulp_rpm PRs. Would it be a major hassle to untangle? |
dralley
approved these changes
May 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #372 to be merged first.fixes: #371