Move simple writing code to utils - #370
Merged
Merged
Conversation
gerrod3
force-pushed
the
pub_utils_refactor
branch
6 times, most recently
from
May 13, 2021 17:53
d9f0495 to
3b24f4e
Compare
dralley
reviewed
May 13, 2021
| def write_simple_index(project_names, streamed=False): | ||
| """Writes the simple index.""" | ||
| simple = Template(simple_index_template) | ||
| context = {"projects": map(lambda x: (x, canonicalize_name(x)), project_names)} |
Contributor
There was a problem hiding this comment.
Would rather use a list comprehension
context = {"projects": [canonicalize_name(x) for x in project_names]}
dralley
approved these changes
May 13, 2021
gerrod3
force-pushed
the
pub_utils_refactor
branch
from
May 13, 2021 20:19
3b24f4e to
c7b34ae
Compare
[noissue]
gerrod3
force-pushed
the
pub_utils_refactor
branch
from
May 13, 2021 20:32
c7b34ae to
a2209ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[noissue]
Lots of changes in #367, moving some of them out into separate PRs to make it easier to review.