[PULP-946] Implement PEP 658 - #1031
Merged
Merged
Conversation
github-actions
Bot
added
multi-commit
jobselko
marked this pull request as draft
November 21, 2025 22:11
jobselko
force-pushed
the
pep_658
branch
2 times, most recently
from
December 4, 2025 17:24
848fa89 to
31cd665
Compare
jobselko
force-pushed
the
pep_658
branch
6 times, most recently
from
December 16, 2025 15:44
5e4f2cb to
69e1326
Compare
gerrod3
requested changes
Dec 16, 2025
jobselko
marked this pull request as ready for review
December 16, 2025 22:08
jobselko
force-pushed
the
pep_658
branch
6 times, most recently
from
December 18, 2025 13:43
14bc63c to
0d693f8
Compare
jobselko
force-pushed
the
pep_658
branch
4 times, most recently
from
December 18, 2025 19:59
ad11073 to
33b60c5
Compare
gerrod3
reviewed
Dec 19, 2025
gerrod3
left a comment
gerrod3
left a comment
Contributor
There was a problem hiding this comment.
The migration logic looks correct to me, just wondering what error messaging we should be doing.
jobselko
commented
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1047