stream: remove path parameter in stream error functions#22792
Open
Girgias wants to merge 2 commits into
Open
Conversation
Instead rely on the mechanism gated by the error_include_args INI to display them
Girgias
marked this pull request as ready for review
July 18, 2026 20:19
Girgias
requested review from
LamentXU123,
bukka,
devnexen and
kamil-tekiela
as code owners
July 18, 2026 20:19
Member
|
I think the (FWIW as background: When I originally implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead rely on the mechanism gated by the error_include_args INI to display them.
Kinda realising that because https://wiki.php.net/rfc/display_error_function_args and https://wiki.php.net/rfc/stream_errors were voted in parrallel some of the interactions weren't really thought out.