Skip to content

stream: remove path parameter in stream error functions#22792

Open
Girgias wants to merge 2 commits into
php:masterfrom
Girgias:2026-07-stream_error_api_path_args
Open

stream: remove path parameter in stream error functions#22792
Girgias wants to merge 2 commits into
php:masterfrom
Girgias:2026-07-stream_error_api_path_args

Conversation

@Girgias

@Girgias Girgias commented Jul 17, 2026

Copy link
Copy Markdown
Member

Instead rely on the mechanism gated by the error_include_args INI to display them.

Kinda realising that because https://wiki.php.net/rfc/display_error_function_args and https://wiki.php.net/rfc/stream_errors were voted in parrallel some of the interactions weren't really thought out.

Instead rely on the mechanism gated by the error_include_args INI to display them
@NattyNarwhal

Copy link
Copy Markdown
Member

I think the param property on the StreamError will be null this way. I think if we want to keep that property as-is on the stream error side, it'd be better to just knock out the php_error_docref1 call in php_stream_report_errors.

(FWIW as background: When I originally implemented error_include_args, I'm pretty sure it predated the stream errors effort. For that, I was also thinking of non-stream stuff and legacy code unlikely to adopt stream contexts, so the little overlap of weirdness here is that param property, which seems tied to streams being the only real php_error_docref1 consumer. Not sure what would be better on that side.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants