feat: extend PopperProps in derivative component types #11934
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-11934.surge.sh A11y report: https://patternfly-react-pr-11934-a11y.surge.sh Preview: https://pf-react-pr-11934.surge.sh A11y report: https://pf-react-pr-11934-a11y.surge.sh |
logonoff
force-pushed
the
menucontainer
branch
3 times, most recently
from
July 23, 2025 20:17
fb8e369 to
cf608bc
Compare
logonoff
changed the title
PopperProps for MenuPopperPropsPopperProps in derivative component types
nicolethoen
reviewed
Jul 25, 2025
logonoff
force-pushed
the
menucontainer
branch
3 times, most recently
from
July 28, 2025 18:18
8f64e28 to
6ac728c
Compare
logonoff
force-pushed
the
menucontainer
branch
from
September 17, 2025 15:46
466c705 to
f458df2
Compare
kmcfaul
reviewed
Sep 23, 2025
kmcfaul
left a comment
kmcfaul
left a comment
Contributor
There was a problem hiding this comment.
My only concern with these changes is that the PopperProps interface is not visible on the site. Can we add the interface to each relevant md file's props array?
logonoff
force-pushed
the
menucontainer
branch
from
September 23, 2025 19:05
f458df2 to
8c84913
Compare
Member
Author
Done |
nicolethoen
approved these changes
Sep 23, 2025
thatblindgeye
approved these changes
Sep 23, 2025
kmcfaul
approved these changes
Sep 23, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Closes #11929
Closes #11574
Additional issues: