fix: Server option routeAllowList is bypassable through batch sub-requests (GHSA-p84r-h6rx-f2xr)

[mtrezza]

Issue

Server option routeAllowList is bypassable through batch sub-requests (GHSA-p84r-h6rx-f2xr)

Tasks

• Add tests

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR extends route allow-list enforcement from middleware to batch sub-requests by refactoring middleware helpers into reusable decision functions, applying them during batch handling, and adding comprehensive test coverage for sub-request rejection and bypass scenarios.

Changes

Route Allow-List Enforcement for Batch Sub-Requests

Layer / File(s)	Summary
Route allow-list normalization and decision logic src/middlewares.js	normalizeRouteAllowListPath removes mount prefix, trims slashes, and strips query strings. New exported isRouteAllowed centralizes allow-list logic by allowing unset lists, master/maintenance auth, or matching paths against regex. enforceRouteAllowList refactored to use the new helper and shared path normalization in error messages.
Batch sub-request allow-list enforcement src/batch.js	Imports isRouteAllowed and createSanitizedError. During batch handling, each sub-request's routable path is checked; disallowed paths throw OPERATION_FORBIDDEN with sanitized errors including the HTTP method and path.
Batch sub-request enforcement test suite spec/RouteAllowList.spec.js	Tests verify rejection of disallowed sub-request paths, success with allowlisted paths, full-batch rejection when any sub-request is disallowed, and master-key bypass of allow-list rules.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• parse-community/parse-server#10389: Implements the core route allow-list enforcement middleware that this PR extends to batch sub-requests.
• parse-community/parse-server#10371: Also modifies src/batch.js to add per-sub-request rejection logic (nested /batch blocking), overlapping in batch enforcement patterns.
• parse-community/parse-server#10214: Modifies batch sub-request handling in src/batch.js for rate-limit enforcement, sharing the same per-subrequest check insertion point.

🚥 Pre-merge checks | ✅ 5 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The pull request description is completely empty, missing all required template sections including Issue, Approach, and Tasks checklist.	Add a comprehensive pull request description following the template, including the Issue being fixed (GHSA-p84r-h6rx-f2xr details), the Approach taken (route allow-list enforcement in batch requests), and completion status of Tasks.
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	PR properly fixes routeAllowList bypass in batch endpoint by enforcing per-sub-request checks with secure path normalization, regex matching, error sanitization, and comprehensive test coverage.
Engage In Review Feedback	✅ Passed	PR created on 2026-05-27 with single commit; no reviewers assigned and no review comments present to engage with, making the check not yet applicable.
Title check	✅ Passed	The title begins with the required 'fix:' prefix and clearly describes the security vulnerability being addressed in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.60%. Comparing base (0ae0ed3) to head (a1bb037).
⚠️ Report is 1 commits behind head on alpha.

Files with missing lines	Patch %	Lines
src/middlewares.js	91.30%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha   #10482      +/-   ##
==========================================
+ Coverage   92.58%   92.60%   +0.01%     
==========================================
  Files         193      193              
  Lines       16884    16893       +9     
  Branches      234      234              
==========================================
+ Hits        15632    15643      +11     
+ Misses       1229     1227       -2     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 9.9.1-alpha.3

[parseplatformorg]

🎉 This change has been released in version 9.10.0