test: allow half-open CONNECT tunnel sockets - #64973
Open
trivikr wants to merge 1 commit into
Open
Conversation
CONNECT tunnels are full-duplex. When the upstream socket receives a FIN while the client-to-upstream pipe is still draining, the default socket behavior can produce EPIPE or ECONNRESET errors. Keep the upstream socket half-open so both directions can drain. Separate request logs from transport errors to verify that teardown completes without errors. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
nodejs-github-bot
added
needs-ci
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64973 +/- ##
==========================================
- Coverage 90.27% 90.27% -0.01%
==========================================
Files 762 762
Lines 247515 247520 +5
Branches 46683 46680 -3
==========================================
- Hits 223447 223445 -2
- Misses 15485 15500 +15
+ Partials 8583 8575 -8 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Aug 4, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/reliability/issues?q=%22test-https-proxy-request-invalid-char-in-url%22
CONNECT tunnels are full-duplex. When the upstream socket receives a FIN while the client-to-upstream pipe is still draining, the default socket behavior can produce EPIPE or ECONNRESET errors.
Keep the upstream socket half-open so both directions can drain. Separate request logs from transport errors to verify that teardown completes without errors.
Assisted-by: codex:gpt-5.6-sol