test: do not use common.isMainThread#56768
Merged
Merged
Conversation
nodejs-github-bot
added
needs-ci
lpinca
force-pushed
the
fix/failing-test
branch
from
January 26, 2025 07:18
8df802a to
8e37fb9
Compare
lpinca
changed the title
targos
approved these changes
Jan 26, 2025
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
`common.isMainThread` was removed in nodejs@8caa1dcee63b2c6fd7a9, use the `isMainThread` export of the `worker_threads` module instead.
lpinca
force-pushed
the
fix/failing-test
branch
from
January 26, 2025 07:58
8e37fb9 to
70d4d2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56768 +/- ##
==========================================
- Coverage 89.22% 89.21% -0.01%
==========================================
Files 662 662
Lines 192125 192125
Branches 36972 36981 +9
==========================================
- Hits 171421 171411 -10
- Misses 13543 13546 +3
- Partials 7161 7168 +7 |
jasnell
approved these changes
Jan 26, 2025
Collaborator
legendecas
approved these changes
Jan 26, 2025
legendecas
added
the
author ready
Collaborator
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 80c70ee |
Merged
This was referenced Mar 17, 2025
This was referenced Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.isMainThreadwas removed in8caa1dcee63b2c6fd7a9, use the
isMainThreadexport of theworker_threadsmodule instead.