[FIX] ASR: reuse full SHAPE_RANGE grid in clean_windows (include beta=3.5)#115
Open
sappelhoff wants to merge 1 commit into
Open
[FIX] ASR: reuse full SHAPE_RANGE grid in clean_windows (include beta=3.5)#115sappelhoff wants to merge 1 commit into
sappelhoff wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 83.10% 83.10%
=======================================
Files 25 25
Lines 2817 2817
=======================================
Hits 2341 2341
Misses 476 476 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Note: includes the |
Open
…=3.5) clean_windows hardcoded np.arange(1.7, 3.5, 0.15), a 12-point grid that excludes the beta=3.5 endpoint, overriding the correct 13-point SHAPE_RANGE that fit_eeg_distribution defaults to. Reuse SHAPE_RANGE so the KL grid search can select beta=3.5.
6817547 to
01fe3b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clean_windowshardcodednp.arange(1.7, 3.5, 0.15), a 12-point grid that excludes thebeta=3.5endpoint, overriding the correct 13-pointSHAPE_RANGEthatfit_eeg_distributiondefaults to. ReuseSHAPE_RANGEso the KL grid search can selectbeta=3.5.Testing
Added a regression test that spies on the
shape_rangeargumentclean_windowspasses down (now the full 13-point grid incl 3.5), plus a fit-level test showing the dropped endpoint changes the selected shape parameter. Fulltests/test_asr.pypasses;ruffclean.