Skip to content

[FIX] ASR: reuse full SHAPE_RANGE grid in clean_windows (include beta=3.5)#115

Open
sappelhoff wants to merge 1 commit into
nbara:masterfrom
sappelhoff:fix/asr-cleanwindows-shape-range
Open

[FIX] ASR: reuse full SHAPE_RANGE grid in clean_windows (include beta=3.5)#115
sappelhoff wants to merge 1 commit into
nbara:masterfrom
sappelhoff:fix/asr-cleanwindows-shape-range

Conversation

@sappelhoff

Copy link
Copy Markdown
Collaborator

clean_windows hardcoded np.arange(1.7, 3.5, 0.15), a 12-point grid that excludes the beta=3.5 endpoint, overriding the correct 13-point SHAPE_RANGE that fit_eeg_distribution defaults to. Reuse SHAPE_RANGE so the KL grid search can select beta=3.5.

Testing

Added a regression test that spies on the shape_range argument clean_windows passes down (now the full 13-point grid incl 3.5), plus a fit-level test showing the dropped endpoint changes the selected shape parameter. Full tests/test_asr.py passes; ruff clean.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.10%. Comparing base (1fcfbfd) to head (01fe3b4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files          25       25           
  Lines        2817     2817           
=======================================
  Hits         2341     2341           
  Misses        476      476           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sappelhoff

Copy link
Copy Markdown
Collaborator Author

Note: includes the nonlinear_eigenspace reproducibility fix from #118. test_asr_class[*-riemann] compares incremental-vs-bulk output with a loose tolerance and is flaky on CI because that path used an unseeded RNG; this can trip on any PR regardless of what it changes. #118 is the root fix — once it merges first, this commit drops out on rebase.

@sappelhoff sappelhoff mentioned this pull request Jul 14, 2026
…=3.5)

clean_windows hardcoded np.arange(1.7, 3.5, 0.15), a 12-point grid that
excludes the beta=3.5 endpoint, overriding the correct 13-point SHAPE_RANGE
that fit_eeg_distribution defaults to. Reuse SHAPE_RANGE so the KL grid
search can select beta=3.5.
@nbara nbara force-pushed the fix/asr-cleanwindows-shape-range branch from 6817547 to 01fe3b4 Compare July 16, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant