Skip to content

Revert #57896 - #58857

Merged
Andrew Branch (andrewbranch) merged 2 commits into
microsoft:mainfrom
andrewbranch:revert-57896
Jun 13, 2024
Merged

Revert #57896#58857
Andrew Branch (andrewbranch) merged 2 commits into
microsoft:mainfrom
andrewbranch:revert-57896

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Jun 13, 2024

Copy link
Copy Markdown
Member

My attempt (#58831) to just disable #57896 was incomplete, so this is the full revert instead.

@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 13, 2024
@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure Daniel Rosenwasser (@DanielRosenwasser) and Ryan Cavanaugh (@RyanCavanaugh) are aware of the changes, just as a heads up.

@jakebailey

Jake Bailey (jakebailey) commented Jun 13, 2024

Copy link
Copy Markdown
Member

Does this also undo Wesley's change? Or does that still work?

@andrewbranch

Andrew Branch (andrewbranch) commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

The only interaction between my work and #58176 is how often package.jsons that one of us is doing a lookup for is already cached because of a lookup that the other is doing.

@andrewbranch

Andrew Branch (andrewbranch) commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

TypeScript Bot (@typescript-bot) cherry-pick to release-5.5

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick to release-5.5 ✅ Started ❌ Results

@typescript-bot

TypeScript Bot (typescript-bot) commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Hey, Andrew Branch (@andrewbranch)! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/9508013806

jakebailey
Jake Bailey (jakebailey) approved these changes Jun 13, 2024
View reviewed changes

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Jun 13, 2024
Merged
@andrewbranch
Andrew Branch (andrewbranch) merged commit 5628973 into microsoft:main Jun 13, 2024
@andrewbranch
Andrew Branch (andrewbranch) deleted the revert-57896 branch June 13, 2024 23:40
Daniel Rosenwasser (DanielRosenwasser) pushed a commit that referenced this pull request Jun 14, 2024
@andrewbranch
Pick #58857 to release-5.5 (#58858)
39c9eeb
@andrewbranch Andrew Branch (andrewbranch) mentioned this pull request Jul 9, 2024
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes
@sheetalkamat Sheetal Nandi (sheetalkamat) Awaiting requested review from sheetalkamat
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

TypeScript 5.5.2

Development

Successfully merging this pull request may close these issues.

5 participants

@andrewbranch @typescript-bot @jakebailey @sandersn @DanielRosenwasser