fix(charts): pie chart innerRadius undefined incorrect rendering #10104
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect Python code generation for Altair pie charts when optional mark properties (notably innerRadius) are present but unset, which previously resulted in invalid kwargs being emitted.
Changes:
- Filter out
undefinedandnullvalues from Vega-Lite mark properties before converting them into Python kwargs. - Add a regression test ensuring
innerRadius: undefineddoes not appear in the generated.mark_arc(...)call.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/components/data-table/charts/chart-spec/altair-generator.ts | Skips undefined/null mark properties so generated Altair code omits invalid kwargs. |
| frontend/src/components/data-table/charts/tests/altair-generator.test.ts | Adds coverage for innerRadius: undefined to prevent regressions in pie/donut codegen. |
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci rename test
ohmdelta
force-pushed
the
pie_chart_donut_fix
branch
from
5d57905 to
98b0d1f
Compare
Contributor
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.23.14-dev32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
By default the pie chart visualisation has donut size (innerRadius) set to undefined. Filtering out undefined and null values in the altair chart generator prevents undefined values from populating the python args.
Before
After
Closes #10103
📋 Pre-Review Checklist
✅ Merge Checklist