chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #60
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#60hyperpolymath wants to merge 3 commits into
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8c). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review 🚫 Blocked 0 resolved / 1 findingsAutomated estate top-up that populates derivable placeholders and removes boilerplate architecture files, but derives an invalid project name from the README H1 ("What Is This?") that breaks machine identifiers, generates nonexistent repository URLs, and produces invalid BibTeX citation keys containing spaces and special characters. 🚨 Bug: "What Is This?" used as project name breaks machine identifiers📄 guix.scm:4 📄 guix.scm:10 📄 guix.scm:21 📄 guix.scm:66 📄 Containerfile:4 📄 docs/attribution/CITATIONS.adoc:12 📄 docs/attribution/CITATIONS.adoc:19 📄 docs/attribution/CITATIONS.adoc:23 📄 docs/attribution/CITATIONS.adoc:27 📄 docs/attribution/CITATIONS.adoc:31 📄 docs/attribution/CITATIONS.adoc:8 PROJECT_NAME was derived from the README H1 literal "What Is This?", but that string contains spaces and a 🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Important Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
![gitar-bot[bot]](https://avatars.mcszy.xyz/in/827041?s=60&v=4){kind=small}
| ;; Copyright (c) 2026 Jonathan D.A. Jewell (hyperpolymath) <j.d.a.jewell@open.ac.uk> | ||
| ;; | ||
| ;; Guix package definition for {{PROJECT_NAME}} | ||
| ;; Guix package definition for What Is This? |
There was a problem hiding this comment.
🚨 Bug: "What Is This?" used as project name breaks machine identifiers
PROJECT_NAME was derived from the README H1 literal "What Is This?", but that string contains spaces and a ?, which is invalid wherever the value is consumed as an identifier rather than prose. In .guix-channel ((name 'What Is This?), line 9) and guix.scm ((name "What Is This?"), line 21) it produces malformed Scheme/Guix package names — Guix package names must be lowercase with no spaces, and the bare symbol 'What Is This? is unparseable. In Containerfile/.devcontainer/Containerfile the documented build commands (podman build -t What Is This?-dev ..., line 6) yield invalid OCI image tags, and WORKDIR /workspaces/What Is This? (.devcontainer/Containerfile line 27) is an unquoted path that splits into multiple arguments. The correct name appears to be atsiser (the repo/manifest name). Substitute the real machine-safe project name (e.g. atsiser) rather than the README title, and quote paths that legitimately need a display name.
Was this helpful? React with 👍 / 👎
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
…t a value
The estate top-up sweep substituted {{PROJECT}} here along with every other
token. This line is a DETECTOR list: the comment above it says these rules
detect corrupt/template/stale state files, so the tokens named in it are the
ones whose PRESENCE means a state file is broken.
Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it
made the detector reject any state file containing this repo's own uppercased
name — the opposite of what the rule is for.
Same failure class as a template recipe rewriting the incident record that
documents its own bug: substituting tokens inside a thing that is ABOUT tokens.
Nothing else in this PR changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous commit on this branch was written by a script that read the file through a shell command substitution. $(...) strips trailing newlines and printf '%s' does not put one back, so the file lost its final newline and the diff showed "\ No newline at end of file". Content is otherwise byte-identical to that commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 participant
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code