ci: pin go-choppy/ossutil-github-action to a SHA in the OSS-deploy workflows#4141
Open
kobihikri wants to merge 1 commit into
Open
ci: pin go-choppy/ossutil-github-action to a SHA in the OSS-deploy workflows#4141kobihikri wants to merge 1 commit into
kobihikri wants to merge 1 commit into
Conversation
…ploy workflows This third-party action is pinned to the mutable @master branch (it redirects to yjcyxky/ossutil-github-action, a personal repo last updated in 2022) while being handed the Aliyun OSS access key + secret as inputs. Pin to the current master commit so a force-move/compromise of that action can't run with the OSS credentials. Affects deploy-to-oss, deploy-standalone-to-oss, sync-skills-to-oss. Assisted by an AI tool; verified against the workflows and the action's repo myself. Signed-off-by: Kobi Hikri <kobi.hikri@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The OSS-deploy workflows run
go-choppy/ossutil-github-action@master— a third-party action pinned to a mutable branch — and pass it the Aliyun OSS credentials directly as inputs (accessKey: ${{ secrets.ACCESS_KEYID }},accessSecret: ${{ secrets.ACCESS_KEYSECRET }}). This pins it to the current commit SHA across all three workflows.Why
@masterresolves to whatever that branch's HEAD is at run time. The action redirects toyjcyxky/ossutil-github-action, a personal repo whose last commit was 2022-05-26 — so it's dormant and a natural target. If that branch were force-moved or the account compromised (the class of thing that happened withtj-actions/changed-files), the injected code would run in a job holding the OSS access key + secret foross://higress-ai/(which serves the public helm charts, tarballs, andinstall.sh). Because the secrets are passed as direct inputs, they'd be trivially exfiltratable.Pinning to a full commit SHA (
7fe73c7, the currentmaster) keeps behavior identical while removing the moving-target window. Changed indeploy-to-oss.yaml,deploy-standalone-to-oss.yaml, andsync-skills-to-oss.yaml.Since the action is dormant, you may also want to vendor or replace it long-term — happy to help if useful.
DCO signed-off.
Disclosure: I used an AI tool to help spot this and prepare the change; I verified the action's repo and the pinned SHA myself and take responsibility for it.