Fix page-load TypeError from removed #db-setup-open element#48
Open
Jada-Q wants to merge 1 commit into
Open
Conversation
The header DB Setup button was changed to a direct link to setup.html, but the modal wiring still calls addEventListener on the removed #db-setup-open element. The resulting TypeError on every page load also prevents the listeners after it (close button, ESC key, tab switching, copy, generate SQL) from being registered. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index.htmlthrows aTypeError: Cannot read properties of null (reading 'addEventListener')on every page load.The header DB Setup button was changed at some point to a direct link to
setup.html, but the modal wiring still doesdbOpenBtn.addEventListener(...)on the removed#db-setup-openelement. Because the error is thrown mid-wiring, the listeners registered after it (modal close button, ESC key, DB tab switching, copy, generate SQL) are silently skipped as well.This change guards the missing trigger with a null check, so the remaining listeners register and the console stays clean.
Validation
index.htmllogs the TypeError at thedbOpenBtn.addEventListenerline (reproduced on currentmain)🤖 Generated with Claude Code