chore(generator): enable system tests#17730
Draft
ohmayr wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements the system test session in noxfile.py to run the system test suite against Showcase, controlled by the RUN_SYSTEM_TESTS environment variable. The feedback suggests improving the parsing of this environment variable by failing fast and raising a ValueError if an invalid or empty value is provided, rather than silently falling back to a default.
Comment on lines
+824
to
+825
| if os.environ.get("RUN_SYSTEM_TESTS", "true") == "false": | ||
| session.skip("RUN_SYSTEM_TESTS is set to false, skipping") |
Contributor
There was a problem hiding this comment.
When parsing the RUN_SYSTEM_TESTS environment variable, if a user explicitly sets an invalid value (such as whitespace-only or an invalid boolean string), we should fail fast and raise an error to notify them of the invalid configuration rather than silently falling back to a default value.
run_env = os.environ.get("RUN_SYSTEM_TESTS", "true")
if not run_env.strip():
raise ValueError("RUN_SYSTEM_TESTS cannot be empty or whitespace-only")
run_system_tests = run_env.strip().lower()
if run_system_tests not in ["true", "false"]:
raise ValueError(f"Invalid value for RUN_SYSTEM_TESTS: {run_env}")
if run_system_tests == "false":
session.skip("RUN_SYSTEM_TESTS is set to false, skipping")References
- When parsing environment variables, if a user explicitly sets an invalid value (such as whitespace-only), fail fast and raise an error to notify them of the invalid configuration rather than silently falling back to a default value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.