Add option to hide namespace in logs#578
Closed
donatas wants to merge 5 commits into
Closed
Conversation
donatas
changed the title
Author
|
@TooTallNate please review |
Author
Member
|
Hi there - I'm 👎 personally with adding yet another env var. Could you weigh in on #582? |
Qix-
added
discussion
Member
|
Closing in favor of #582. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our log collector expects the output to be of some format (across systems, that write logs) and now the only thing I can't control is the namespace, prepended to each line.
It's enabled by default, passing environment variable allows hiding it.
PR contains tests that cover default behavior (namespace + log) and the new feature.