perf: increase sync page size from 100 to 1000 records#3584
Draft
markovejnovic wants to merge 2 commits into
Draft
perf: increase sync page size from 100 to 1000 records#3584markovejnovic wants to merge 2 commits into
markovejnovic wants to merge 2 commits into
Conversation
Contributor
Fossier: Manual Review Requested
Score BreakdownTotal Score: 50.0/100 | Confidence: 100% | Outcome: REVIEW
|
Validates SQLite write performance at the new sync page size. The old page size was 100; the new page size is 1000.
10× fewer HTTP round-trips per sync. The server default page_size is 1100 (atuin-server/src/settings.rs:79), so 1000 is well within the server's accepted limit.
markovejnovic
force-pushed
the
perf/sync-page-size
branch
from
c1474f9 to
065e853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push_batchbenchmark covering batch sizes 1, 10, 100, and 1000record/sync.rs), reducing HTTP round-trips per sync by 10×page_sizeis already 1100 (atuin-server/src/settings.rs:79), so 1000 is well within the accepted limitTest plan
cargo check -p atuin-clientcompiles cleancargo test -p atuin-clientpasses (sync tests don't exercise live sync)cargo bench -p atuin-client --bench benchmarks -- push_batchruns all 4 batch sizes