DLSR-258: Add title attribute to iframe in media viewer#1225
Merged
Conversation
This may or may not be sufficient for https://uclalibrary.atlassian.net/browse/DLSR-258, but at the very minimum it's a stopgap until I can take a deeper look.
akohler
approved these changes
Apr 15, 2026
akohler
left a comment
akohler
left a comment
Member
There was a problem hiding this comment.
Given the vague requirement that there needs to be a description of what is in the iFrame on the item view page, adding a generic title seems enough to me. If this doesn't make Siteimprove happy enough, we'll need more specific requirements.
Member
|
@sourcefilter The cypress check is still running. Dunno how long that will take, so feel free to merge now or once it finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may or may not be sufficient for https://uclalibrary.atlassian.net/browse/DLSR-258, but at the very minimum it's a stopgap until I can take a deeper look.