dev: fix dev-only issue with detecting SolrDocument class#1224
Merged
Conversation
In some cases, a cached object was treated as not belonging to a reloaded "SolrDocument" class. This should only happen in dev mode, but comparing based on class name instead of identity will be more robust. This was getting in the way of testing DLSR-9, though the connection is pretty weak. I'm not sure why it didn't come up before – I assume after some upgrades we're using a changed version of the development server?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, a cached object was treated as not belonging to a reloaded "SolrDocument" class. This should only happen in dev mode, but comparing based on class name instead of identity will be more robust.
This was getting in the way of testing DLSR-9, though the connection is pretty weak. I'm not sure why it didn't come up before – I assume after some upgrades we're using a changed version of the development server?