Add Slack DM toggle for channel thread @-mentions#3554
Draft
adboio wants to merge 2 commits into
Draft
Conversation
Opt-in setting (default off) in the Slack settings section, gated behind the project-bluebird flag. Reads/writes the new /api/code/user_settings/ endpoint; delivery itself is backend-driven via the team's Slack integration (PostHog/posthog#72087). Generated-By: PostHog Code Task-Id: 69e0939c-e6e1-4efa-9d5e-771b88f03b5a
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Generated-By: PostHog Code Task-Id: 69e0939c-e6e1-4efa-9d5e-771b88f03b5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@-mentions in channel threads only surface in the polled Activity feed — if you're not in the app, you don't find out someone tagged you. PostHog/posthog#72087 adds backend-driven Slack DMs on mention (opt-in, via the team's existing Slack integration); this PR adds the client-side toggle for that preference.
Changes
SlackMentionNotificationsSettingssection rendered in Slack settings below the inbox-notifications block: a "Mention notifications" switch ("Get a Slack DM when someone @-mentions you in a channel thread"). Hidden unless theproject-bluebirdflag is on and a Slack workspace is connected (the parent section owns the connect prompt).useCodeUserNotificationSettings/...Mutationshooks (query + optimistic-update mutation with revert-and-toast on failure), following theuseSignalUserAutonomyMutationspattern.getCodeUserNotificationSettings/updateCodeUserNotificationSettingsagainst the new/api/code/user_settings/endpoint, with theCodeUserNotificationSettingstype in@posthog/shared/domain-types.SETTING_CHANGED(setting_name: "slack_mention_notifications").Depends on PostHog/posthog#72087 — until that deploys, the settings fetch 404s and the section shows the switch in its default (off) state.
How did you test this?
Code review against the sibling Slack settings sections only — I (Claude, via a PostHog Code cloud task) could not run
pnpm typecheck/pnpm lintor the app in this sandbox (no installed workspace), so CI is the verification here. No new unit tests: the hooks mirroruseSignalUserAutonomyMutationsand the component is presentational; sibling settings sections carry no component tests either.Automatic notifications
Created with PostHog Code