Keep new browser tabs in the current channel#3544
Open
jakesciotto wants to merge 1 commit into
Open
Conversation
A new tab opened while viewing a channel canvas now lands on that channel instead of jumping to the personal (#me) folder. landOnDefault now navigates to the current route's channelId when present, falling back to #me only when the user isn't in a channel. Generated-By: PostHog Code Task-Id: 314ad5e2-0f6c-4d71-90ff-c45396f2343c
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
jakesciotto
marked this pull request as ready for review
July 17, 2026 14:59
jakesciotto
enabled auto-merge (squash)
July 17, 2026 15:00
Contributor
|
Reviews (1): Last reviewed commit: "Keep new browser tabs in the current cha..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When working on a canvas inside a channel and opening a new tab (the "+" button or Cmd/Ctrl+T), the new tab jumped to the personal
#mefolder instead of staying in the channel currently in view. A new tab should be relative to the channel you're already working in.Changes
landOnDefaultinBrowserTabStrip.tsxnow navigates to the current route'schannelIdwhen there is one, so a new tab opened from a channel canvas stays in that channel. It falls back to#meonly when the user isn't in a channel, and to the Code new-task screen when channels are off.How did you test this?
pnpm --filter @posthog/ui typecheckpasses cleanly for the changed file. Not manually verified in the running app.Automatic notifications
Created with PostHog from a Slack thread