Skip to content

[Common][PyTorch] EP dispatch with unfused MXFP8 quantization - #3270

Open
phu0ngng wants to merge 13 commits into
NVIDIA:mainfrom
phu0ngng:ep_mxfp8
Open

[Common][PyTorch] EP dispatch with unfused MXFP8 quantization#3270
phu0ngng wants to merge 13 commits into
NVIDIA:mainfrom
phu0ngng:ep_mxfp8

Conversation

@phu0ngng

Copy link
Copy Markdown
Collaborator

Description

This PR adds MXFP8 support to the dispatch op of the NCCL EP path. The dispatch op is used in two places, and MXFP8 applies to both:

  • Dispatch forward bfloat16 tokens are quantized to MXFP8 internally and dispatched to the target experts; recv is returned as a per-expert GroupedTensor.
  • Combine backward the result-grad is scattered back to expert positions through the same (reverse) dispatch op, quantized to MXFP8, returning the expert-output grad as a per-expert GroupedTensor.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

PyTorch frontend (transformer_engine/pytorch/ep.py, distributed.py, csrc/extensions/ep.cpp)**

  • The dispatch op quantizes bfloat16 tokens to MXFP8 internally when the buffer's dispatch_quant_recipe is set (MXFP8BlockScaling only for now); dispatch-forward recv is returned as a per-expert GroupedTensor. A pre-quantized input is rejected.
  • Combine backward reuses the dispatch op to scatter the result-grad: it quantizes the grad to MXFP8 and returns the expert-output grad as a per-expert GroupedTensor. Combine forward is unchanged (high-precision).
  • Recv data and block scales share a single caller-supplied (optionally symm-mem-backed) buffer, sliced into data-then-scale regions; the same convention is used for the combine backward grad buffer.

Common backend (common/ep/ep_backend.cpp, include/.../ep.h, comm_window.h)**

  • Backend and public headers extended to carry block-scale buffers/windows through the dispatch primitive.

NCCL EP submodule**

  • Bumped 3rdparty/nccl-extensions to the revision providing block-scaled dispatch.

Tests (tests/cpp_distributed/test_ep.cu, tests/pytorch/distributed/run_ep.py, run_test_ep.sh)**

  • Added C++ distributed coverage for the MXFP8 dispatch path.
  • Added PyTorch MXFP8 test passes for dispatch forward (normal, zero-copy, eager IO modes) and combine backward, gated behind a dedicated NVTE_EP_MXFP8_PASS run since the grouped path pins the per-expert alignment process-wide.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds MXFP8 support to NCCL expert-parallel dispatch and combine backward.

  • Routes MXFP8 token data and block scales together through the common backend and PyTorch bindings.
  • Returns per-expert grouped quantized tensors and supports caller-provided or symmetric-memory-backed buffers.
  • Adds distributed C++ and PyTorch coverage for normal, zero-copy, eager, and combine-backward paths.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported repository ignore-file deletion has been fully reverted in the current head.

Important Files Changed

Filename Overview
transformer_engine/pytorch/ep.py Adds recipe-driven MXFP8 quantization, grouped output construction, buffer slicing, and autograd handling for dispatch forward and combine backward.
transformer_engine/pytorch/csrc/extensions/ep.cpp Extends EP bindings to validate and transport MXFP8 data and scale-inverse tensors, including symmetric-memory window offsets.
transformer_engine/common/ep/ep_backend.cpp Builds NCCL descriptors for block scales and routes them alongside MXFP8 payloads in forward and reverse dispatch.
transformer_engine/pytorch/distributed.py Adds lifecycle tracking and explicit release support for the process-wide symmetric-memory pool.
tests/pytorch/distributed/run_ep.py Adds distributed MXFP8 dispatch and combine-backward coverage across allocated and caller-provided buffers.
tests/cpp_distributed/test_ep.cu Verifies that MXFP8 data rows and corresponding scale rows follow the same expert-routing permutation.

Sequence Diagram

sequenceDiagram
  participant User
  participant PyTorch as PyTorch EP
  participant Binding as C++ Binding
  participant Backend as NCCL EP Backend
  participant Experts
  User->>PyTorch: ep_dispatch(BF16 tokens, MXFP8 recipe)
  PyTorch->>PyTorch: Quantize data and block scales
  PyTorch->>Binding: Dispatch data + scale buffers
  Binding->>Backend: nvte_ep_dispatch
  Backend->>Experts: Route token data and scales
  Experts-->>PyTorch: GroupedTensor per expert
  User->>PyTorch: ep_combine backward(gradient)
  PyTorch->>Binding: Reverse dispatch data + scales
  Binding->>Backend: nvte_ep_combine_bwd
  Backend-->>User: Grouped MXFP8 expert-output gradient
Loading

Reviews (7): Last reviewed commit: "Merge branch 'main' into ep_mxfp8" | Re-trigger Greptile

@phu0ngng
phu0ngng requested a review from zhongbozhu July 28, 2026 23:33
Comment thread transformer_engine/pytorch/ep.py Outdated
@phu0ngng

Copy link
Copy Markdown
Collaborator Author

/te-ci L1 pytorch

Comment thread .gitignore
Comment thread transformer_engine/pytorch/ep.py Outdated
Comment thread transformer_engine/pytorch/ep.py
Comment thread transformer_engine/pytorch/ep.py Outdated
Comment thread transformer_engine/pytorch/ep.py Outdated
Comment thread transformer_engine/pytorch/ep.py
Comment thread transformer_engine/pytorch/ep.py Outdated
Comment thread transformer_engine/pytorch/distributed.py Outdated
Comment thread transformer_engine/pytorch/distributed.py
Comment thread transformer_engine/pytorch/ep.py
Comment thread transformer_engine/pytorch/ep.py Outdated
phu0ngng added 11 commits August 5, 2026 17:18
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…der CUDA graph capture

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
…CUDA-graph capture

Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
Signed-off-by: Phuong Nguyen <phuonguyen@nvidia.com>
@phu0ngng

phu0ngng commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci L1

@phu0ngng

phu0ngng commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci L1

@phu0ngng

phu0ngng commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants