[All] Bump minimum supported cuDNN version to 9.12 - #3236
Conversation
Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Greptile SummaryThis PR bumps the documented minimum cuDNN requirement in two RST files. Both
Confidence Score: 4/5Safe to merge after resolving the version number discrepancy between the PR description and the actual doc changes. Both changed files consistently set the minimum to 9.11, but the PR title and opening description say 9.12. One of these is a typo, and whichever number is wrong should be corrected before merging to avoid a misleading changelog entry. Files Needing Attention: Both README.rst and docs/installation.rst reference 9.11 — confirm this is the intended target version. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PR: Bump min cuDNN] --> B[README.rst
9.3+ → 9.11+]
A --> C[docs/installation.rst
9.3 → 9.11]
A --> D[PR Title & Description
claims: 9.12]
D -. mismatch .-> B
D -. mismatch .-> C
Reviews (4): Last reviewed commit: "Merge branch 'main' into update-min-cudn..." | Re-trigger Greptile |
KshitijLakhani
left a comment
There was a problem hiding this comment.
IIUC, the minimum version check does not mean that we cannot build with <9.11 right ? It just means that older versions (features) are just unsupported, right ? So the 9.11 is merely a lowest tested/supported version and not a hard runtime/build floor right ?
If my understand is right we do not need to worry about compilation checks during build and these:
However, I think these below two might needs anotehr look right ?
- Wouldn't the notebook here need a refresh :
docs/examples/attention/attention.ipynb? - Also, would we want to refresh the assert in here:
tutorial_generation_gemma_with_te.ipynb?
|
For min version, maybe we could match with a previous PyTorch NGC container (e.g. cuDNN 9.12.0.46 for 25.08) from frameworks support matrix. |
|
I'll do a bit more cleanup throughout the code to support this update, and will update to cuDNN 9.12. |
|
|
||
| * CUDA: 12.1+ (Hopper/Ada/Ampere), 12.8+ (Blackwell) with compatible NVIDIA drivers | ||
| * cuDNN: 9.3+ | ||
| * cuDNN: 9.11+ |
There was a problem hiding this comment.
Version mismatch between PR description and documentation
The PR title and opening description both say the minimum is being bumped to 9.12, but both RST files set it to 9.11. If the correct target is 9.11, the PR title and description need a correction; if 9.12 is intended, both docs files need updating. Either way, readers relying on the PR title/description for the changelog entry will see a different number than the docs.
Description
This PR raises the minimum supported cuDNN version from 9.3 to 9.12 in Transformer Engine. 9.12 is about a year old and we encourage users to update their cuDNN version if they haven't.
Type of change
Changes
Checklist: