Skip to content

Fix:版本列表不会自动分类愚人节版本#6018

Open
RyogiMutsuki wants to merge 15 commits into
Meloong-Git:mainfrom
LuoYun-Team:auto-fool-sort
Open

Fix:版本列表不会自动分类愚人节版本#6018
RyogiMutsuki wants to merge 15 commits into
Meloong-Git:mainfrom
LuoYun-Team:auto-fool-sort

Conversation

@RyogiMutsuki

@RyogiMutsuki RyogiMutsuki commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

PR 改动:

  • GetMcFoolName 现在会自动判断版本是否在 4 月 1 日发布，如果没有对应描述，那么默认描述为 [Year] | 愚人节版本
  • 版本列表现在会根据发布时间正确分类愚人节版本

Resolve #6016

@RyogiMutsuki RyogiMutsuki added · 优化 等待确认 已经过社区确认，等待开发者确认 labels Apr 2, 2025
@RyogiMutsuki

RyogiMutsuki commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator Author

image

效果预览

@RyogiMutsuki RyogiMutsuki changed the title 自动分类愚人节版本 版本列表不会自动分类愚人节版本 Apr 2, 2025
@RyogiMutsuki RyogiMutsuki changed the title 版本列表不会自动分类愚人节版本 Fix:版本列表不会自动分类愚人节版本 Apr 2, 2025
@Open-KFC

This comment was marked as resolved.

Sign in to view
@RyogiMutsuki

RyogiMutsuki commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator Author

huh?

等下午重新调试一遍（

@RyogiMutsuki RyogiMutsuki added 社区处理中 社区正在调查或处理该项 and removed 等待确认 已经过社区确认，等待开发者确认 labels Apr 2, 2025
@Open-KFC

This comment was marked as outdated.

Sign in to view
@RyogiMutsuki

RyogiMutsuki commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

捞个 suggest，不然得等晚修再看了（

Open-KFC
Open-KFC reviewed Apr 2, 2025
View reviewed changes
Comment thread Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb Outdated
Open-KFC
Open-KFC reviewed Apr 2, 2025
View reviewed changes
Comment thread Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb Outdated
@Open-KFC

This comment was marked as off-topic.

Sign in to view
@wyc-26

wyc-26 commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

我该怎么做才能在一次suggest里添加多个代码段的修改啊

暂定评论，最后一起交

@Open-KFC

This comment was marked as off-topic.

Sign in to view
@RyogiMutsuki

RyogiMutsuki commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator Author

暂定评论，最后一起交

如何暂定评论？是写了评论之后什么都不按然后几条都写完之后右上角的 review changs -> submit review 吗

写完一条直接写下一条，写完再 submit review

RyogiMutsuki and others added 2 commits April 2, 2025 17:23
@RyogiMutsuki @Open-KFC
Update Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb
477968e 
Co-authored-by: OpenKFC <168712411+Open-KFC@users.noreply.github.com>
@RyogiMutsuki @Open-KFC
Update Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb
1e693d9 
Co-authored-by: OpenKFC <168712411+Open-KFC@users.noreply.github.com>
Open-KFC
Open-KFC suggested changes Apr 2, 2025
View reviewed changes

@Open-KFC Open-KFC left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有一条（

Comment thread Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb Outdated
@RyogiMutsuki @Open-KFC
Update Plain Craft Launcher 2/Modules/Minecraft/ModMinecraft.vb
7b5c9af 
Co-authored-by: OpenKFC <168712411+Open-KFC@users.noreply.github.com>
@RyogiMutsuki RyogiMutsuki requested review from LTCatt and Open-KFC April 2, 2025 09:26
@RyogiMutsuki RyogiMutsuki added 等待确认 已经过社区确认，等待开发者确认 and removed 社区处理中 社区正在调查或处理该项 labels Apr 2, 2025
@LTCatt LTCatt added 处理中 开发者正在调查或处理该项 🟩 低 优先度：低 and removed 等待确认 已经过社区确认，等待开发者确认 labels Apr 2, 2025
@Silverteal

Silverteal commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

我的想法，默认占位符无论是有趣程度还是信息量还不如纯日期。
如果要让占位符更有“改的必要”，它就应该更加“愚人节”一点，如：这个版本很懒，还没有设置个人签名/这个版本害羞地隐藏了个人签名

@RyogiMutsuki

RyogiMutsuki commented Apr 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

我觉得可以改成 由于龙猫/Mojang太懒了，所以这个版本还没有个人签名。（bushi

cc @LTCatt

Edit:

如果真要玩有趣的话，我觉得可以弄一个列表玩随机显示，这样加啥都可以

甚至可以开放投稿，吸引用户前来赞助

收入++

@Open-KFC

Open-KFC commented Apr 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

喂，ToString("yyyy/M/d")是Date类的方法，JToken类的ToString接受的第一个参数是一个枚举，传字符串进去会导致类型转换异常，打开构建产出进到下载页面就能看到弹窗报错要求反馈了。
把最新的提交 revert 掉吧（

CType(String,Date)

把字符串解析Date对象也行（
版本列表 json 里的日期格式是yyyy/M/d H:mm:ss

@RyogiMutsuki

RyogiMutsuki commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator Author

把最新的提交 revert 掉吧（

CType(String,Date)

System.InvalidCastException:从类型 String 到 Date 的转换无效

@Open-KFC Open-KFC mentioned this pull request Apr 11, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Open-KFC Open-KFC Awaiting requested review from Open-KFC
@LTCatt LTCatt Awaiting requested review from LTCatt

Assignees

No one assigned

Labels

· Bug 处理中 开发者正在调查或处理该项 🟩 低 优先度：低

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[转发 #6015] 游戏版本分类有误

5 participants

@RyogiMutsuki @Open-KFC @wyc-26 @Silverteal @LTCatt