Add Firefox Beta & Nightly to QSB#6885
Open
Dharshika-11 wants to merge 9 commits into
Open
Conversation
Removed strings for 'Allow home screen rotation' and 'When phone is rotated'. Added strings for 'Resume exploration after reconnect' and its summary.
Update strings.xml to modify settings strings
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo new Kotlin ChangesFirefox Beta & Nightly QSB Providers
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Goooler
changed the title
![coderabbitai[bot]](https://avatars.mcszy.xyz/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lawnchair/src/app/lawnchair/qsb/providers/FirefoxBeta.kt (1)
18-24: ⚡ Quick winBoth Firefox providers carry the same dead voice-intent path.
The shared root cause issupportVoiceIntent = falsewhile still overridinghandleCreateVoiceIntent(), making the override unreachable through the current provider flow.
lawnchair/src/app/lawnchair/qsb/providers/FirefoxBeta.kt#L18-L24: remove the override (or enable/support/test voice before keeping it).lawnchair/src/app/lawnchair/qsb/providers/FirefoxNightly.kt#L18-L24: apply the same cleanup for parity and clarity.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@lawnchair/src/app/lawnchair/qsb/providers/FirefoxBeta.kt` around lines 18 - 24, The handleCreateVoiceIntent() method override is unreachable dead code because supportVoiceIntent is set to false, meaning the override will never be invoked through the provider flow. Remove the handleCreateVoiceIntent() override method (which includes the Intent construction with action, INTENT_FLAGS, and setClassName call) from both FirefoxBeta.kt (lines 18-24) and FirefoxNightly.kt (lines 18-24) to eliminate the dead code and maintain clarity in both files.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@lawnchair/src/app/lawnchair/qsb/providers/FirefoxBeta.kt`:
- Around line 18-24: The handleCreateVoiceIntent() method override is
unreachable dead code because supportVoiceIntent is set to false, meaning the
override will never be invoked through the provider flow. Remove the
handleCreateVoiceIntent() override method (which includes the Intent
construction with action, INTENT_FLAGS, and setClassName call) from both
FirefoxBeta.kt (lines 18-24) and FirefoxNightly.kt (lines 18-24) to eliminate
the dead code and maintain clarity in both files.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c9e73ce7-265f-4def-aabe-4a200f4ff300
📒 Files selected for processing (3)
lawnchair/src/app/lawnchair/qsb/providers/FirefoxBeta.ktlawnchair/src/app/lawnchair/qsb/providers/FirefoxNightly.ktres/values/strings.xml
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to extend Lawnchair’s QSB (Quick Search Bar) provider list by adding Firefox Beta and Firefox Nightly as selectable search providers, along with the necessary display strings.
Changes:
- Added two new QSB provider definitions:
FirefoxBetaandFirefoxNightly. - Added string resources for the new provider names (and adjusted placement of existing rotation strings).
- Added two new “resume exploration” strings (currently not referenced elsewhere).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
res/values/strings.xml |
Adds provider name strings; also introduces “resume exploration” strings and reorders rotation strings/comments. |
lawnchair/src/app/lawnchair/qsb/providers/FirefoxBeta.kt |
New QSB provider definition for Firefox Beta. |
lawnchair/src/app/lawnchair/qsb/providers/FirefoxNightly.kt |
New QSB provider definition for Firefox Nightly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+363
to
+364
| <string name="resume_exploration_title">Resume exploration after reconnect</string> | ||
| <string name="resume_exploration_summary">Automatically resume exploration when connection is restored</string> |
Comment on lines
+9
to
+12
| name = R.string.search_provider_firefox_beta, | ||
| icon = R.drawable.ic_firefox_beta, | ||
| themedIcon = R.drawable.ic_firefox_beta_tinted, | ||
| themingMethod = ThemingMethod.TINT, |
Comment on lines
+7
to
+18
| data object FirefoxBeta : QsbSearchProvider( | ||
| id = "FirefoxBeta", | ||
| name = R.string.search_provider_firefox_beta, | ||
| icon = R.drawable.ic_firefox_beta, | ||
| themedIcon = R.drawable.ic_firefox_beta_tinted, | ||
| themingMethod = ThemingMethod.TINT, | ||
| packageName = "org.mozilla.firefox_beta", | ||
| action = "org.mozilla.fenix.OPEN_TAB", | ||
| className = "org.mozilla.fenix.IntentReceiverActivity", | ||
| website = "https://play.google.com/store/apps/details?id=org.mozilla.firefox_beta", | ||
| type = QsbSearchProviderType.APP, | ||
| supportVoiceIntent = false, |
Comment on lines
+9
to
+12
| name = R.string.search_provider_firefox_nightly, | ||
| icon = R.drawable.ic_firefox_nightly, | ||
| themedIcon = R.drawable.ic_firefox_nightly_tinted, | ||
| themingMethod = ThemingMethod.TINT, |
Comment on lines
+7
to
+18
| data object FirefoxNightly : QsbSearchProvider( | ||
| id = "FirefoxNightly", | ||
| name = R.string.search_provider_firefox_nightly, | ||
| icon = R.drawable.ic_firefox_nightly, | ||
| themedIcon = R.drawable.ic_firefox_nightly_tinted, | ||
| themingMethod = ThemingMethod.TINT, | ||
| packageName = "org.mozilla.fenix", | ||
| action = "org.mozilla.fenix.OPEN_TAB", | ||
| className = "org.mozilla.fenix.IntentReceiverActivity", | ||
| website = "https://play.google.com/store/apps/details?id=org.mozilla.fenix", | ||
| type = QsbSearchProviderType.APP, | ||
| supportVoiceIntent = false, |
Goooler
reviewed
Jun 16, 2026
Goooler
reviewed
Jun 16, 2026
Goooler
reviewed
Jun 16, 2026
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add string resources for Firefox Beta and Firefox Nightly search providers.
Changes
search_provider_firefox_betasearch_provider_firefox_nightlyTesting
Closes #6439
Summary by CodeRabbit
Summary by CodeRabbit