Skip to content

deps(MCP): Bump flagsmith-common to 3.12, pyfakefs to 6#8007

Merged
khvn26 merged 1 commit into
mainfrom
fix/mcp-pyfakefs-6
Jul 14, 2026
Merged

deps(MCP): Bump flagsmith-common to 3.12, pyfakefs to 6#8007
khvn26 merged 1 commit into
mainfrom
fix/mcp-pyfakefs-6

Conversation

@khvn26

@khvn26 khvn26 commented Jul 14, 2026

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

The Renovate run after #8005 aborted with result: "lockfile-error": flagsmith-common[test-tools] requires pyfakefs>=6,<7 since 3.11.0, which is unsatisfiable against the MCP's pyfakefs>=5.0.0,<6.0.0 pin. Renovate bumps one package per branch, so it can't resolve this itself, and the failed relock aborts the whole repository run.

In this PR, we bump flagsmith-common to >=3.12.0 and pyfakefs to >=6.0.0,<7.0.0 together.

How did you test this code?

CI green.

flagsmith-common[test-tools] requires pyfakefs>=6,<7 since 3.11.0, so
the two must move together. Pass the new required protocol argument to
the common.core.otel provider builders, preserving the current
http/protobuf behaviour.

beep boop
@khvn26 khvn26 requested a review from a team as a code owner July 14, 2026 18:32
@khvn26 khvn26 requested review from emyller and removed request for a team July 14, 2026 18:32
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 14, 2026 6:32pm
flagsmith-frontend-preview Ignored Ignored Preview Jul 14, 2026 6:32pm
flagsmith-frontend-staging Ignored Ignored Preview Jul 14, 2026 6:32pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6c506da9-d543-40ba-b627-176a3cac8e1b

📥 Commits

Reviewing files that changed from the base of the PR and between 4510b72 and a637a4f.

⛔ Files ignored due to path filters (1)
  • mcp/uv.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • mcp/pyproject.toml
  • mcp/src/flagsmith_mcp/telemetry.py
  • mcp/tests/unit/test_telemetry.py

📝 Walkthrough

Walkthrough

MCP dependency constraints now require newer flagsmith-common and pyfakefs versions. Telemetry setup explicitly configures both OTLP log and trace exporters to use http/protobuf. The OTLP telemetry unit test now verifies the trace provider receives this protocol argument.

Estimated code review effort: 2 (Simple) | ~10 minutes


Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-8007 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-8007 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8007 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-8007 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8007 Finished ✅ Results

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  17.4 seconds
commit  a637a4f
info  🔄 Run: #18257 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  19.2 seconds
commit  a637a4f
info  🔄 Run: #18257 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  48.7 seconds
commit  a637a4f
info  🔄 Run: #18257 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  18.8 seconds
commit  a637a4f
info  🔄 Run: #18257 (attempt 1)

@github-actions

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@khvn26 khvn26 merged commit e55b56d into main Jul 14, 2026
35 checks passed
@khvn26 khvn26 deleted the fix/mcp-pyfakefs-6 branch July 14, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants