Maniacs Patch - Partial Implementation of game option commands - #3487
Open
jetrotal wants to merge 3 commits into
Open
Maniacs Patch - Partial Implementation of game option commands#3487jetrotal wants to merge 3 commits into
jetrotal wants to merge 3 commits into
Conversation
Contributor
Author
|
this pr requires an update in liblcf, to include: bool maniac_fast_forward_text = false;
int32_t maniac_frame_skip_mode = 0;
int32_t maniac_battle_origin = 0;
int32_t message_face_width = 48;
int32_t message_face_height = 48;
&& l.maniac_fast_forward_text == r.maniac_fast_forward_text
&& l.maniac_frame_skip_mode == r.maniac_frame_skip_mode
&& l.maniac_battle_origin == r.maniac_battle_origin
&& l.message_face_width == r.message_face_width
&& l.message_face_height == r.message_face_height
|
Member
|
Can you try to figure out which chunk IDs Maniacs uses to save this? E.g. create a save before and after applying the options, then compare the XML savefile. This won't help for unknown chunks. The Player will dump unknown chunks into the logfile which should be in |
Contributor
Author
|
couldn't find any relevant diff between save files. here's a unknown chunk report: saves and map files: |
27 tasks
Member
|
Can confirm that this doesn't persist in the savedata. It isn't even reset when returning to the Title (imo this should be changed). |
Member
|
Correction. Only persisted are "Size of Face" and "Position of Battle Screen". SaveSystem:
|
Added support for various Maniac Patch runtime engine settings via a new command handler in Game_Interpreter. Introduced new Game_System methods for pause screen when focus lost, fatal mix settings, fast-forward text, frame skip mode and message mouse disabling. Updated Player and Window_Message to respect these options, including frame skipping and fast-forwarding message text. missing features are: battle origin, and message face size.
Ghabry
force-pushed
the
maniacs-gameOptions
branch
from
May 14, 2026 12:01
e89f80d to
e6fcffb
Compare
mgambrell
added a commit
to mgambrell/Player
that referenced
this pull request
Jun 10, 2026
The event-command reference (3001-3033 + undocumented 3022/3023/3024 + modified baseline commands) at per-index parameter level, with sub-op tables, the RE-verified battle trigger 6/7 firing model, and an EasyRPG status rollup (10 FULL / 9 PARTIAL / 2 STUB / 1 WONTFIX / 10 MISSING vs the 220325 surface). The 3018 SetGameOption op-map conflict is RESOLVED by consumption-site adjudication across both the 220325 (Beloved Rapture) and 211010 reference binaries: the official-docs / PR EasyRPG#3487 reading is correct (op0 run-when-inactive, op1 FatalMix FPS/TestPlay/RShift-skip, op2 pic-max, op3 frameskip, op4 mouse-msg gate, op5 3x3 battle-UI anchor, op6 pic rebuild, op7 FaceSet cell = 220325-only). Critic pass fixed 12 sourcing errors. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mgambrell
added a commit
to mgambrell/Player
that referenced
this pull request
Jun 10, 2026
… PR EasyRPG#3487 Records two divergences between the applied PR EasyRPG#3487 and the binary RE: op 6 (animLimit per TPC/changelog vs picture-array rebuild per first-pass RE; animLimit favored) and op-1 bit-4 (binary gates fast-forward on right-Shift held; PR sets it unconditionally). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d message as a new mappable key
Everything that should ignore the frame rate uses DEFAULT_FPS now
Ghabry
changed the title
Ghabry
force-pushed
the
maniacs-gameOptions
branch
from
August 3, 2026 14:36
e6fcffb to
8f2f3af
Compare
Member
|
@jetrotal this should work now Most notable change to your code is that RSHIFT is now a key bind to fast forward text as this feature is cool in general. And the frame rate handling is now setting the Game FPS directly instead of doing some fast forward multiplier trickery (which conflicted with normal fast forward) |
Ghabry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for various Maniac Patch runtime engine settings via a new command handler in Game_Interpreter. Introduced new Game_System methods for pause screen when focus lost, fatal mix settings, fast-forward text, frame skip mode and message mouse disabling. Updated Player and Window_Message to respect these options, including frame skipping and fast-forwarding message text.
missing features are: battle origin, and message face size.