Skip to content

Devextreme: migrate gulp transpile-systemjs to nx#34317

Merged
vorobey merged 2 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
vorobey:feature/gulp-to-nx-systemjs
Jul 15, 2026
Merged

Devextreme: migrate gulp transpile-systemjs to nx#34317
vorobey merged 2 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
vorobey:feature/gulp-to-nx-systemjs

Conversation

@vorobey

@vorobey vorobey commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vorobey
vorobey requested a review from a team July 15, 2026 11:17
@vorobey vorobey self-assigned this Jul 15, 2026
@vorobey
vorobey requested a review from Copilot July 15, 2026 11:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates DevExtreme’s gulp transpile-systemjs task to an Nx executor in devextreme-nx-infra-plugin, and updates the devextreme package to use the new build:systemjs target directly (removing the old gulp wiring).

Changes:

  • Added a new devextreme-nx-infra-plugin:transpile-systemjs executor (schema + implementation) that spawns testing/systemjs-builder.js --transpile=<mode> per mode in parallel.
  • Updated packages/devextreme’s build:systemjs target to use the new executor and removed the legacy gulp task/script registration.
  • Added E2E tests for the new executor and documented the migration in AGENTS.md.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/nx-infra-plugin/src/executors/transpile-systemjs/transpile-systemjs.impl.ts New Nx executor implementation orchestrating parallel systemjs-builder runs.
packages/nx-infra-plugin/src/executors/transpile-systemjs/schema.ts New TS options interface for the executor.
packages/nx-infra-plugin/src/executors/transpile-systemjs/schema.json New JSON schema for executor options (builder script + modes).
packages/nx-infra-plugin/src/executors/transpile-systemjs/executor.ts Nx entrypoint re-exporting the implementation.
packages/nx-infra-plugin/src/executors/transpile-systemjs/executor.e2e.spec.ts E2E coverage validating successful runs and failure propagation.
packages/nx-infra-plugin/executors.json Registers the new transpile-systemjs executor.
packages/nx-infra-plugin/AGENTS.md Documents the gulp→Nx migration and where old artifacts were removed.
packages/devextreme/project.json Switches build:systemjs from nx:run-script to the new executor; removes deleted gulp file from inputs.
packages/devextreme/package.json Removes the obsolete build:systemjs npm script (gulp transpile-systemjs).
packages/devextreme/gulpfile.js Removes registration of the deleted build/gulp/systemjs task file.
packages/devextreme/build/gulp/systemjs.js Deletes the legacy gulp task implementation.

@vorobey
vorobey marked this pull request as ready for review July 15, 2026 12:02
@GoodDayForSurf
GoodDayForSurf requested a review from Copilot July 15, 2026 12:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@vorobey
vorobey merged commit bacc168 into DevExpress:feature/gulp-to-nx-migration Jul 15, 2026
99 checks passed
ajivanyandev pushed a commit to ajivanyandev/DevExtreme that referenced this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants