Skip to content

Feature/gulp to nx test env#34305

Merged
vorobey merged 2 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
vorobey:feature/gulp-to-nx-test-env
Jul 15, 2026
Merged

Feature/gulp to nx test env#34305
vorobey merged 2 commits into
DevExpress:feature/gulp-to-nx-migrationfrom
vorobey:feature/gulp-to-nx-test-env

Conversation

@vorobey

@vorobey vorobey commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@vorobey
vorobey requested review from a team and Copilot July 14, 2026 13:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the migration from Gulp tasks to Nx targets by introducing a test-env Nx target and moving the bundler-config watch workflow to Nx, supported by new capabilities in the concatenate-files executor (multi-pass concatenation and watch mode).

Changes:

  • Enhanced devextreme-nx-infra-plugin:concatenate-files to support additionalPasses and watch/watchPaths, with E2E coverage for both.
  • Added Nx targets in packages/devextreme/project.json for test-env and build:devextreme-bundler-config:watch, and updated Gulp tasks to delegate to Nx.
  • Centralized chokidar as a root dev dependency (and removed it from devextreme-scss).

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-lock.yaml Moves chokidar lock entry from devextreme-scss to workspace root.
packages/nx-infra-plugin/src/executors/concatenate-files/schema.ts Introduces ConcatenatePass and extends schema to support additional passes + watch options.
packages/nx-infra-plugin/src/executors/concatenate-files/schema.json Adds JSON schema for additionalPasses, watch, and watchPaths.
packages/nx-infra-plugin/src/executors/concatenate-files/executor.e2e.spec.ts Adds E2E coverage for additionalPasses and watch rebuild behavior.
packages/nx-infra-plugin/src/executors/concatenate-files/concatenate-files.impl.ts Implements multi-pass execution and watch mode (via chokidar).
packages/nx-infra-plugin/AGENTS.md Documents newly migrated gulp tasks and their Nx equivalents.
packages/devextreme/project.json Adds build:devextreme-bundler-config:watch and test-env Nx targets.
packages/devextreme/gulpfile.js Delegates gulp test-env to pnpm nx test-env devextreme.
packages/devextreme/build/gulp/bundler-config.js Replaces Gulp pipeline with Nx delegation for bundler-config + watch.
packages/devextreme-scss/package.json Removes chokidar from package-local devDependencies.
package.json Adds chokidar to workspace root devDependencies.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/devextreme/build/gulp/bundler-config.js
@vorobey
vorobey force-pushed the feature/gulp-to-nx-test-env branch from 3b1d8c1 to 901ea74 Compare July 14, 2026 14:13
@vorobey
vorobey marked this pull request as ready for review July 14, 2026 14:14
@vorobey
vorobey force-pushed the feature/gulp-to-nx-test-env branch from 901ea74 to 01880c5 Compare July 14, 2026 15:53
@vorobey vorobey self-assigned this Jul 14, 2026
@vorobey
vorobey merged commit 54e53e9 into DevExpress:feature/gulp-to-nx-migration Jul 15, 2026
159 of 163 checks passed
vorobey added a commit that referenced this pull request Jul 15, 2026
vorobey added a commit that referenced this pull request Jul 15, 2026
vorobey added a commit that referenced this pull request Jul 16, 2026
vorobey added a commit that referenced this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants