Feature/gulp to nx test env#34305
Merged
vorobey merged 2 commits intoJul 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the migration from Gulp tasks to Nx targets by introducing a test-env Nx target and moving the bundler-config watch workflow to Nx, supported by new capabilities in the concatenate-files executor (multi-pass concatenation and watch mode).
Changes:
- Enhanced
devextreme-nx-infra-plugin:concatenate-filesto supportadditionalPassesandwatch/watchPaths, with E2E coverage for both. - Added Nx targets in
packages/devextreme/project.jsonfortest-envandbuild:devextreme-bundler-config:watch, and updated Gulp tasks to delegate to Nx. - Centralized
chokidaras a root dev dependency (and removed it fromdevextreme-scss).
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Moves chokidar lock entry from devextreme-scss to workspace root. |
| packages/nx-infra-plugin/src/executors/concatenate-files/schema.ts | Introduces ConcatenatePass and extends schema to support additional passes + watch options. |
| packages/nx-infra-plugin/src/executors/concatenate-files/schema.json | Adds JSON schema for additionalPasses, watch, and watchPaths. |
| packages/nx-infra-plugin/src/executors/concatenate-files/executor.e2e.spec.ts | Adds E2E coverage for additionalPasses and watch rebuild behavior. |
| packages/nx-infra-plugin/src/executors/concatenate-files/concatenate-files.impl.ts | Implements multi-pass execution and watch mode (via chokidar). |
| packages/nx-infra-plugin/AGENTS.md | Documents newly migrated gulp tasks and their Nx equivalents. |
| packages/devextreme/project.json | Adds build:devextreme-bundler-config:watch and test-env Nx targets. |
| packages/devextreme/gulpfile.js | Delegates gulp test-env to pnpm nx test-env devextreme. |
| packages/devextreme/build/gulp/bundler-config.js | Replaces Gulp pipeline with Nx delegation for bundler-config + watch. |
| packages/devextreme-scss/package.json | Removes chokidar from package-local devDependencies. |
| package.json | Adds chokidar to workspace root devDependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
vorobey
force-pushed
the
feature/gulp-to-nx-test-env
branch
from
July 14, 2026 14:13
3b1d8c1 to
901ea74
Compare
vorobey
marked this pull request as ready for review
July 14, 2026 14:14
vorobey
force-pushed
the
feature/gulp-to-nx-test-env
branch
from
July 14, 2026 15:53
901ea74 to
01880c5
Compare
ajivanyandev
approved these changes
Jul 15, 2026
vorobey
merged commit Jul 15, 2026
54e53e9
into
DevExpress:feature/gulp-to-nx-migration
159 of 163 checks passed
vorobey
added a commit
that referenced
this pull request
Jul 15, 2026
vorobey
added a commit
that referenced
this pull request
Jul 15, 2026
vorobey
added a commit
that referenced
this pull request
Jul 16, 2026
vorobey
added a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.