[Feature Request] Partial CODEOWNER reviews #147252
Replies: 1 comment
-
|
I like this idea, but I'm not sure this should only be limited to CODEOWNERS. Currently, the "Viewed" checkbox on files within a Pull Request is a helpful but limited feature. It collapses the file for the current reviewer, acting as a personal progress tracker. I think we can extending this concept to create a "Partial Approve" state. When a reviewer submits their review, they should have the option to formally approve the files they have marked as "Viewed". These files would then appear collapsed for all other reviewers on the PR, with a clear indication of who approved them. This would signal to the team that a specific portion of the PR has been vetted, allowing others to focus their attention on the remaining changes. The ProblemThe ideal of small, atomic Pull Requests is not always achievable in practice. A common scenario is a PR that introduces a breaking change in a core module. To keep the system buildable and functional, the developer must also update all dependent modules within the same PR. This results in large, multi-faceted PRs that require input from different domain experts or code owners. For example:
In the current system, there is no effective way for the
Proposed SolutionI propose enhancing the review workflow with a "Partial Approve" capability:
This creates a trusted, shared state. Other reviewers can now confidently skip the sections approved by domain experts and focus their energy where it's most needed. They would, of course, retain the ability to expand and inspect the files if they wish. Thank you for considering this proposal. I believe this feature would be a significant quality-of-life improvement for countless development teams on GitHub. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
Pull requests will often trigger CODEOWNER reviews based on certain files within the repository. For larger pull requests the reviewers will then focus on their own areas of ownership and approve the PR based on the partial review.
I often see PR review comments that look something like:
This can then result in approved pull requests that can be merged, even though only part of the changeset has been reviewed fully.
I would like to see GitHub have the ability for reviewers to give partial approvals for a subset of a pull request. This could be certain chunks, certain files, or simply clearing the CODEOWNER restriction without explicit approval.
A pull request would then only be mergable once all files / chunks have received approval.
Beta Was this translation helpful? Give feedback.
All reactions